Skip to content

Added some missing baudrates #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Added some missing baudrates #34

merged 1 commit into from
Jan 9, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 1, 2022

This is a tentative fix to add missing baud rates. It is known that there may be some issues on some OS, so testing is required to see if everything is working as expected.

The Arduino IDE 1.8.x has the following baud rates in the selector:

protected String[] serialRateStrings = {
  "300", "1200", "2400", "4800", "9600",
  "19200", "38400", "57600", "74880",
  "115200", "230400", "250000", "500000",
  "1000000", "2000000"};

I've added the missing 74880, 250000, and also 31250 (that is not available in the Arduino IDE 1.8.x).

@cmaglie cmaglie added type: enhancement Proposed improvement priority: high Resolution is a high priority criticality: high Of high impact labels Dec 1, 2022
@cmaglie cmaglie self-assigned this Dec 1, 2022
This was linked to issues Dec 1, 2022
Serial monitor max baudrate limited to 115200 (legacy IDE has 250000, 1000000, ...) #20
Closed
Custom baud rate to serial monitor #33
Closed
@cmaglie
Copy link
Member Author

cmaglie commented Dec 1, 2022

test builds in https://github.com/arduino/serial-monitor/actions/runs/3591605334

@cmaglie cmaglie requested a review from umbynos December 1, 2022 10:39
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 1, 2022
@mariuszdec
Copy link

Hi all,
those new baudrates are importatnt to me.
I have just downloaded 2.03 dated on 15-th December but there is not available yet.
I understand that we are waiting for umbynos.
Umberto please review this solution.
Best wishes for a new 2023-th year :)
Regards
Mariusz

per1234
per1234 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

MatteoPologruto
MatteoPologruto approved these changes Jan 9, 2023
View reviewed changes
Copy link

@MatteoPologruto MatteoPologruto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes using the sketch SerialEcho, with an Arduino Uno board on Windows 11. The only baudrate value that is giving me some issues is 300, while the others work fine both on the arduino-cli and on the Java Ide. The issues might be related to the board, but I'm not entirely sure.

@cmaglie cmaglie merged commit 6ca61c9 into main Jan 9, 2023
@cmaglie cmaglie deleted the add_baudrates branch January 9, 2023 14:35
@facchinm
Copy link
Member

facchinm commented Jan 9, 2023

I tested the changes using the sketch SerialEcho, with an Arduino Uno board on Windows 11. The only baudrate value that is giving me some issues is 300, while the others work fine both on the arduino-cli and on the Java Ide. The issues might be related to the board, but I'm not entirely sure.

@MatteoPologruto 300bps is a special baud that might not work on UNO/Mega (due to shortcomings in the usb2serial chip firmware), so the failure is "expected"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@umbynos umbynos Awaiting requested review from umbynos

Assignees

@cmaglie cmaglie

Labels
criticality: high Of high impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
5 participants
@cmaglie @mariuszdec @facchinm @per1234 @MatteoPologruto